netdev - Re: [PATCH net 1/3] MAINTAINERS: Add myself as maintainer for socket timestamping and expand file list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250130101811.5459c3f8@kmaincent-XPS-13-7390>
Date: Thu, 30 Jan 2025 10:18:11 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Donald Hunter
 <donald.hunter@...il.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/3] MAINTAINERS: Add myself as maintainer for
 socket timestamping and expand file list

On Wed, 29 Jan 2025 16:39:16 -0800
Jakub Kicinski <kuba@...nel.org> wrote:

> On Tue, 28 Jan 2025 16:35:46 +0100 Kory Maincent wrote:
> > Add myself as maintainer for socket timestamping. I have contributed
> > modifications to the timestamping core to support selection between
> > multiple PTP instances within a network topology.
> > 
> > Expand the file list to include timestamping ethtool support.  
> 
> Hi Kory, is there more context you could provide for this change?
> 
> For core pieces of the stack, with a long history, we tend to
> designate as maintainer folks who review the changes, not just
> write code. According to our development stats that doesn't
> describe you, just yet:
> 
> Top reviewer score:
> 
> 6.12: Negative # 5 ( +6) [ 50] Kory Maincent (Dent Project)
> 6.13: Negative #11 (***) [ 29] Kory Maincent (Dent Project)

Yes indeed, I am not really confident reviewing code part that I don't know
well. My thought that I did not have lots on review in the PTP patch series I
just managed to get merged. So I would try to change that.
Moreover I have changed a bit the management of time stamping configuration so
if there is changes or fixes I could be helpful.
Indeed adding myself as maintainer is a bit overestimated, maybe I could be set
as a reviewer to be in the CC of the patches.

> https://lore.kernel.org/20250121200710.19126f7d@kernel.org
> https://lore.kernel.org/20241119191608.514ea226@kernel.org
> https://lore.kernel.org/20240922190125.24697d06@kernel.org
> 
> That said, I do feel like we're lacking maintainers for sections 
> of the ethtool code. Maybe we could start with adding and entry 
> for you for just:
> 
> > +F:	net/ethtool/tsconfig.c
> > +F:	net/ethtool/tsinfo.c  
> 
> Does that sound fair?

Yes it does. Whether setting me as reviewer for the SOCKET TIMESTAMPING subpart
or adding me as maintainer of these two files it is ok for me. What do you
prefer?

I will try to review more ethtool code now that I began to understand how it
works thanks to my PoE and PTP work. 

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com