netdev - Re: [PATCH RFC net-next v3 2/8] netconsole: Rename userdata to extradata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250130103648.GF113107@kernel.org>
Date: Thu, 30 Jan 2025 10:36:48 +0000
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org,
	rdunlap@...radead.org, kernel-team@...a.com
Subject: Re: [PATCH RFC net-next v3 2/8] netconsole: Rename userdata to
 extradata

On Fri, Jan 24, 2025 at 07:16:41AM -0800, Breno Leitao wrote:
> Rename "userdata" to "extradata" since this structure will hold both
> user and system data in future patches. Keep "userdata" term only for
> data that comes from userspace (configfs), while "extradata" encompasses
> both userdata and future kerneldata.
> 
> These are the rules of the design
> 
> 1. extradata_complete will hold userdata and sysdata (coming)
> 2. sysdata will come after userdata_length
> 3. extradata_complete[userdata_length] string will be replaced at every
>    message
> 5. userdata is replaced when configfs changes (update_userdata())
> 6. sysdata is replaced at every message
> 
> Example:
>   extradata_complete = "userkey=uservalue cpu=42"
>   userdata_length = 17
>   sysdata_length = 7 (space (" ") is part of sysdata)
> 
> Since sysdata is still not available, you will see the following in the
> send functions:
> 
> 	extradata_len = nt->userdata_length;
> 
> The upcoming patches will, which will add support for sysdata, will
> change it to:
> 
> 	extradata_len = nt->userdata_length + sysdata_len;
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Simon Horman <horms@...nel.org>