netdev - Re: KSZ9477 HSR Offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91b842e7-a7c9-49b9-8d14-486f10ea3724@lunn.ch>
Date: Thu, 30 Jan 2025 14:39:47 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Frieder Schrempf <frieder.schrempf@...tron.de>
Cc: Lukasz Majewski <lukma@...x.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: KSZ9477 HSR Offloading

> One more information I just found out: I can leave ksz9477_hsr_join()
> untouched and only remove the feature flags from
> KSZ9477_SUPPORTED_HSR_FEATURES to make things work.
> 
> Broken:
> 
> #define KSZ9477_SUPPORTED_HSR_FEATURES (NETIF_F_HW_HSR_DUP |
> NETIF_F_HW_HSR_FWD)
> 
> Works:
> 
> #define KSZ9477_SUPPORTED_HSR_FEATURES (NETIF_F_HW_HSR_DUP)
> 
> Works:
> 
> #define KSZ9477_SUPPORTED_HSR_FEATURES (NETIF_F_HW_HSR_FWD)
> 
> Works:
> 
> #define KSZ9477_SUPPORTED_HSR_FEATURES (0)

It would be good to define "works". Are the packets getting delivered
to Linux and then the software HSR bridge in Linux is emitting the
packets back out the interfaces? Or is it all happening in hardware
and Linux never sees the packet.

Ideally we want the hardware to be doing all the work, in the "Works"
condition.

	Andrew