netdev - Re: [PATCH net 08/16] udp: convert to dev_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250131191004.95188-1-kuniyu@amazon.com>
Date: Fri, 31 Jan 2025 11:10:04 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <eric.dumazet@...il.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH net 08/16] udp: convert to dev_net_rcu()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 31 Jan 2025 17:13:26 +0000
> TCP uses of dev_net() are safe, change them to dev_net_rcu()

s/TCP/UDP/

> to get LOCKDEP support.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>


[...]
> @@ -1072,7 +1072,7 @@ int __udp6_lib_rcv(struct sk_buff *skb, struct udp_table *udptable,
>  {
>  	enum skb_drop_reason reason = SKB_DROP_REASON_NOT_SPECIFIED;
>  	const struct in6_addr *saddr, *daddr;
> -	struct net *net = dev_net(skb->dev);
> +	struct net *net = dev_net_rcu(skb->dev);

if v2 is needed for chagelog, this line is longer than saddr/daddr one.


>  	struct sock *sk = NULL;
>  	struct udphdr *uh;
>  	bool refcounted;