netdev - Re: [PATCH net 15/16] flow_dissector: use rcu protection to fetch dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250131194623.187-1-kuniyu@amazon.com>
Date: Fri, 31 Jan 2025 11:46:23 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <eric.dumazet@...il.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH net 15/16] flow_dissector: use rcu protection to fetch dev_net()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 31 Jan 2025 17:13:33 +0000
> __skb_flow_dissect() can be called from arbitrary contexts.
> 
> It must extend its rcu protection section to include
> the call to dev_net(), which can become dev_net_rcu().
> 
> This makes sure the net structure can not disappear under us.
> 
> Fixes: 3cbf4ffba5ee ("net: plumb network namespace into __skb_flow_dissect")

The correct tag seems to be

  Fixes: 9b52e3f267a6 ("flow_dissector: handle no-skb use case")

, which moves dev_net() out of rcu_read_lock().

otherwise looks good to me

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>