netdev - Re: [PATCH v4 2/4] dt-bindings: mfd: Add MDIO interface to rtl9301-switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e020ca6-025e-4a88-9aaa-a432d8aa668d@kernel.org>
Date: Fri, 31 Jan 2025 08:26:41 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc: "lee@...nel.org" <lee@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "tsbogend@...ha.franken.de"
 <tsbogend@...ha.franken.de>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
 "linux@...linux.org.uk" <linux@...linux.org.uk>,
 "sander@...nheule.net" <sander@...nheule.net>,
 "markus.stockhausen@....de" <markus.stockhausen@....de>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH v4 2/4] dt-bindings: mfd: Add MDIO interface to
 rtl9301-switch

On 22/01/2025 21:53, Chris Packham wrote:
>>>         };
>>> +
>>> +      mdio-controller {
>> No, no resources here, no unit address. Look at other nodes - they have
>> the resource, the address. Mixing such nodes is clear indication this is
>> not correct hardware description and you do this only for Linux.
>>
>> Fold child device into parent.
> 
> In this particular case all the mdio stuff is actually contained to a 
> range starting at offset 0xca00. I dropped it because it was simpler in 
> the driver to use the full 16-bit address rather than trying to use 
> offsets from the base address that didn't correspond to the datasheet. 
> As you've highlighted that's making the dt-binding impose driver 
> specifics so would adding back `mdio-controller@...0` and `reg = <0xca00 
> 0x200>;` be OK even if the driver doesn't actually use them?


If this matches the hardware, then yes.

Best regards,
Krzysztof