[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250131-kind-rapid-kagu-7fc4c5@krzk-bin>
Date: Fri, 31 Jan 2025 08:33:27 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: lee@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, tsbogend@...ha.franken.de,
hkallweit1@...il.com, linux@...linux.org.uk, sander@...nheule.net,
markus.stockhausen@....de, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v5 2/4] dt-bindings: mfd: Add MDIO interface to
rtl9301-switch
On Fri, Jan 31, 2025 at 02:01:49PM +1300, Chris Packham wrote:
> .../bindings/mfd/realtek,rtl9301-switch.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> index f053303ab1e6..89e10213a4ee 100644
> --- a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> @@ -28,6 +28,9 @@ properties:
> reg:
> maxItems: 1
>
> + mdio-controller:
> + $ref: /schemas/net/realtek,rtl9301-mdio.yaml#
> +
So this mdio-controller looks duplicated now. Why is it needed?
> '#address-cells':
> const: 1
>
> @@ -41,6 +44,10 @@ patternProperties:
> 'i2c@[0-9a-f]+$':
> $ref: /schemas/i2c/realtek,rtl9301-i2c.yaml#
>
> + 'mdio-controller@[0-9a-f]+$':
> + $ref: /schemas/net/realtek,rtl9301-mdio.yaml#
> +
> +
Just one blank line.
Best regards,
Krzysztof
Powered by blists - more mailing lists