netdev - Re: [PATCH net v2 2/2] net: ipv6: fix dst ref loops in rpl, seg6 and ioam6 lwtunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b8d9c6e-cbe6-4c75-b709-c732db0cf331@uliege.be>
Date: Sat, 1 Feb 2025 14:52:05 +0100
From: Justin Iurman <justin.iurman@...ege.be>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
 netdev@...r.kernel.org, edumazet@...gle.com, andrew+netdev@...n.ch,
 horms@...nel.org, dsahern@...nel.org
Subject: Re: [PATCH net v2 2/2] net: ipv6: fix dst ref loops in rpl, seg6 and
 ioam6 lwtunnels

On 1/30/25 17:53, Jakub Kicinski wrote:
> On Thu, 30 Jan 2025 16:12:23 +0100 Justin Iurman wrote:
>>> And perhaps add a selftest at least for the looped cases?
>>
>> ioam6.sh already triggers the looped cases in both inline and encap
>> tests. Not sure about seg6 though, and there is no selftest for rpl.
> 
> Right! To be clear I meant just for seg6 and rpl. The ioam6 test
> is clearly paying off, thanks for putting in the work there! :)

Got it. Of course, I'll see what I can do. And glad the ioam6 selftest 
helped :-) Not sure what the current SRv6 selftests are doing though, 
but it looks like the "looped cases" were not caught. Probably because 
the first segment makes it so that the new dst_entry is not the same as 
the origin (I'll have to double check). I could just add a test with a 
route matching on a subnet, so that the next segment matches too (i.e., 
old dst == new dst). Overall, both seg6 and rpl selftests to detect the 
looped cases would look like "dummy" tests, i.e., useless without 
kmemleak. Does it sound OK?