netdev - Re: [PATCH 00/13] gpiolib: add gpiods_set_array_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Ve+iwrm8dx49+6C7xFJgTQrh3XumKVzKvnYY=00J-j43A@mail.gmail.com>
Date: Sat, 1 Feb 2025 21:47:15 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: David Lechner <dlechner@...libre.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-mmc@...r.kernel.org, netdev@...r.kernel.org, 
	linux-phy@...ts.infradead.org, linux-sound@...r.kernel.org, 
	Linus Walleij <linus.walleij@...aro.org>, Andy Shevchenko <andy@...nel.org>, 
	Geert Uytterhoeven <geert@...ux-m68k.org>, Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>, 
	Ulf Hansson <ulf.hansson@...aro.org>, Peter Rosin <peda@...ntia.se>, Andrew Lunn <andrew@...n.ch>, 
	Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vinod Koul <vkoul@...nel.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Nuno Sá <nuno.sa@...log.com>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 00/13] gpiolib: add gpiods_set_array_value_cansleep

On Sat, Feb 1, 2025 at 6:22 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> On Sat, Feb 1, 2025 at 5:17 PM David Lechner <dlechner@...libre.com> wrote:
> > On 2/1/25 10:14 AM, Bartosz Golaszewski wrote:
> > > On Sat, Feb 1, 2025 at 5:09 PM David Lechner <dlechner@...libre.com> wrote:
> > >> On 2/1/25 4:36 AM, Bartosz Golaszewski wrote:

...

> > >>> This looks good to me except for one thing: the function prefix. I would
> > >>> really appreciate it if we could stay within the existing gpiod_ namespace and
> > >>> not add a new one in the form of gpiods_.
> > >>>
> > >>> Maybe: gpiod_multiple_set_ or gpiod_collected_set...?
> > >>
> > >> I was waiting for someone to complain about the naming. ;-)
> > >>
> > >> I was going for as short as possible, but OK, the most obvious prefix to me
> > >> would be `gpio_descs_...` (to match the first parameter). Any objections to
> > >> that?
> > >
> > > Yes, objection! As far as any exported interfaces go: in my book
> > > "gpio_" is the prefix for legacy symbols we want to go away and
> > > "gpiod_" is the prefix for current, descriptor-based API. Anything
> > > else is a no-go. I prefer a longer name that starts with gpiod_ over
> > > anything that's shorter but doesn't.
> >
> > Oops, that was a typo. I meant to write gpiod_descs_.
>
> Eh... the D in gpioD already stands for "GPIO Descriptor" but if
> there's no better option in your opinion than I guess I can live with
> that.

gpiod_set_many_value_cansleep() ?

-- 
With Best Regards,
Andy Shevchenko