netdev - RE: [PATCH] net: ibm: emac: Use of_get_available_child_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB1134692E120054FAD3830736086EA2@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sun, 2 Feb 2025 10:15:21 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rosen Penev
	<rosenp@...il.com>, Shannon Nelson <shannon.nelson@....com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>, Simon
 Horman <horms@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>, biju.das.au
	<biju.das.au@...il.com>
Subject: RE: [PATCH] net: ibm: emac: Use of_get_available_child_by_name()

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: 01 February 2025 18:49
> Subject: Re: [PATCH] net: ibm: emac: Use of_get_available_child_by_name()
> 
> On Sat, Feb 01, 2025 at 04:57:51PM +0000, Biju Das wrote:
> > Use the helper of_get_available_child_by_name() to simplify
> > emac_dt_mdio_probe().
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > ---
> > This patch is only compile tested and depend upon[1] [1]
> > https://lore.kernel.org/all/20250201093126.7322-1-biju.das.jz@bp.renes
> > as.com/
> > ---
> >  drivers/net/ethernet/ibm/emac/core.c | 17 ++++-------------
> >  1 file changed, 4 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/ibm/emac/core.c
> > b/drivers/net/ethernet/ibm/emac/core.c
> > index 25b8a3556004..079efc5ed9bc 100644
> > --- a/drivers/net/ethernet/ibm/emac/core.c
> > +++ b/drivers/net/ethernet/ibm/emac/core.c
> > @@ -2550,26 +2550,19 @@ static const struct mii_phy_ops
> > emac_dt_mdio_phy_ops = {
> >
> >  static int emac_dt_mdio_probe(struct emac_instance *dev)  {
> > -	struct device_node *mii_np;
> > +	struct device_node *mii_np _free(device_node) =
> > +		of_get_available_child_by_name(dev->ofdev->dev.of_node, "mdio");
> 
> When you are new to a subsystem, it is probably better to send a single patch to help figure out that
> subsystems way of doing thing. It looks like all you patches have the same problem.

Sorry for that, Will send next version with readable code once
dependency patch hits on net-next.

Cheers,
Biju