netdev - Re: [PATCH ethtool-next 08/14] cmis: Enable JSON output support in CMIS modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250203125927.3072e386@kernel.org>
Date: Mon, 3 Feb 2025 12:59:27 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Danielle Ratson <danieller@...dia.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "mkubecek@...e.cz"
 <mkubecek@...e.cz>, "matt@...verse.com.au" <matt@...verse.com.au>,
 "daniel.zahka@...il.com" <daniel.zahka@...il.com>, Amit Cohen
 <amcohen@...dia.com>, NBU-mlxsw <NBU-mlxsw@...hange.nvidia.com>
Subject: Re: [PATCH ethtool-next 08/14] cmis: Enable JSON output support in
 CMIS modules

On Sun, 2 Feb 2025 18:22:18 +0000 Danielle Ratson wrote:
>                 "type": "object",
>                 "properties": {
>                         "br_nominal_units": {
>                                 "type": "string",
>                                 "enum": ["Mbps"] },
>                         "length_(smf)_units": {
>                                 "type": "string",
>                                 "enum": ["km"] },
>                         "length_(om5)_units": {
>                                 "type": "string",
>                                 "enum": ["m"] },
>                         "length_(om4)_units": {
>                                 "type": "string",
>                                 "enum": ["m"] },
>                         "length_(om3)_units": {
>                                 "type": "string",
>                                 "enum": ["m"] },

Hm. I would have expected properties to match the main output.

So:

                 "type": "object",
                 "properties": {
                         "br_nominal": {
                                 "type": "string",
                                 "description": "Nominal bitrate. Unit: Mbps" },
                         "length_(smf)": {
                                 "type": "string",
                                 "description": "Unit: km" },
                         "length_(om5)": {
                                 "type": "string",
                                 "description": "Unit: m" },
                         "length_(om4)": {
                                 "type": "string",
                                 "description": "Unit: m" },
                         "length_(om3)": {
                                 "type": "string",
                                 "description": "Unit: m" },