netdev - Re: [PATCH net-next] r8169: don't scan PHY addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c22b2d03-badd-4c9e-9ed2-7fc77e2586b1@lunn.ch>
Date: Mon, 3 Feb 2025 22:41:23 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: don't scan PHY addresses > 0

On Mon, Feb 03, 2025 at 09:48:00PM +0100, Heiner Kallweit wrote:
> The PHY address is a dummy anyway, because r8169 PHY access registers
> don't support a PHY address. Therefore scan address 0 only, this saves
> some cpu cycles and allows to remove two checks.

The IOCTL interface allows you to access any address on the bus. So
you should probably keep the tests. Setting phy_mask however is a good
idea.

	Andrew