netdev - Re: [PATCH net 15/16] flow_dissector: use rcu protection to fetch dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJCrshU6iqMUuPNuC6caqqw3E0YPLov5Zw2+jM00bKJig@mail.gmail.com>
Date: Mon, 3 Feb 2025 11:09:56 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, eric.dumazet@...il.com, horms@...nel.org, 
	kuba@...nel.org, netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net 15/16] flow_dissector: use rcu protection to fetch dev_net()

On Fri, Jan 31, 2025 at 8:46 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Fri, 31 Jan 2025 17:13:33 +0000
> > __skb_flow_dissect() can be called from arbitrary contexts.
> >
> > It must extend its rcu protection section to include
> > the call to dev_net(), which can become dev_net_rcu().
> >
> > This makes sure the net structure can not disappear under us.
> >
> > Fixes: 3cbf4ffba5ee ("net: plumb network namespace into __skb_flow_dissect")
>
> The correct tag seems to be
>
>   Fixes: 9b52e3f267a6 ("flow_dissector: handle no-skb use case")

Yes, you are correct, thanks !