netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor ice_fdir_create_dflt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6241B6F8156C991FD0B4B6978BF52@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Mon, 3 Feb 2025 03:49:27 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "Polchlopek, Mateusz" <mateusz.polchlopek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor
 ice_fdir_create_dflt_rules() function

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Mateusz Polchlopek
> Sent: 17 January 2025 13:37
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Polchlopek, Mateusz <mateusz.polchlopek@...el.com>; Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor ice_fdir_create_dflt_rules() function
>
> The Flow Director function ice_fdir_create_dflt_rules() calls few times function ice_create_init_fdir_rule() each time with different enum ice_fltr_ptype parameter. Next step is to return error code if error occurred.
>
> Change the code to store all necessary default rules in constant array and call ice_create_init_fdir_rule() in the loop. It makes it easy to extend the list of default rules in the future, without the need of duplicate code more and more.
>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> ---
> .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 21 ++++++++-----------
> 1 file changed, 9 insertions(+), 12 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)