netdev - Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d63b3475-c423-4167-806b-97f22258cb07@hartkopp.net>
Date: Tue, 4 Feb 2025 08:40:29 +0100
From: Oliver Hartkopp <socketcan@...tkopp.net>
To: Reyders Morales <reyders1@...il.com>, kuba@...nel.org
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/networking: Fix basic node example document
 ISO 15765-2

On 03.02.25 23:47, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
> 
> Signed-off-by: Reyders Morales <reyders1@...il.com>

Acked-by: Oliver Hartkopp <socketcan@...tkopp.net>

Thanks!

> ---
>   Documentation/networking/iso15765-2.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>   
>     addr.can_family = AF_CAN;
>     addr.can_ifindex = if_nametoindex("can0");
> -  addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> -  addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>   
>     ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
>     if (ret < 0)