netdev - Re: [PATCH net-next 15/15] net/mlx5e: Avoid WARN_ON when configuring MQPRIO with HTB offload enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nO3271KNxQHN+=ou=QGnxwP3NvGGZXJJA9zSkWqoBecdg@mail.gmail.com>
Date: Tue, 4 Feb 2025 13:51:49 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org, 
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>, Jianbo Liu <jianbol@...dia.com>, 
	Moshe Shemesh <moshe@...dia.com>, Leon Romanovsky <leonro@...dia.com>, Mark Bloch <mbloch@...dia.com>, 
	Carolina Jubran <cjubran@...dia.com>, Yael Chemla <ychemla@...dia.com>, 
	Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net-next 15/15] net/mlx5e: Avoid WARN_ON when configuring
 MQPRIO with HTB offload enabled

On Tue, Feb 4, 2025 at 3:08 AM Tariq Toukan <tariqt@...dia.com> wrote:
>
> From: Carolina Jubran <cjubran@...dia.com>
>
> When attempting to enable MQPRIO while HTB offload is already
> configured, the driver currently returns `-EINVAL` and triggers a
> `WARN_ON`, leading to an unnecessary call trace.
>
> Update the code to handle this case more gracefully by returning
> `-EOPNOTSUPP` instead, while also providing a helpful user message.
>
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Yael Chemla <ychemla@...dia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>


-- 
Regards,
Kalesh AP

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)