netdev - Re: [PATCH net-next] neighbour: remove neigh_parms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250204094714.GN234677@kernel.org>
Date: Tue, 4 Feb 2025 09:47:14 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] neighbour: remove neigh_parms_destroy()

On Mon, Feb 03, 2025 at 03:11:52PM +0000, Eric Dumazet wrote:
> neigh_parms_destroy() is a simple kfree(), no need for
> a forward declaration.
> 
> neigh_parms_put() can instead call kfree() directly.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Thanks Eric,

I agree that this is the case. And I think it has been so since
commit efd7ef1c1929 ("net: Kill hold_net release_net").
Or, IOW, for about 10 years by now.

Reviewed-by: Simon Horman <horms@...nel.org>