netdev - Re: [PATCH net-next 2/2] eth: fbnic: set IFF_UNICAST_FLT to avoid enabling promiscuous mode when adding unicast addrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250204124857.GA234677@kernel.org>
Date: Tue, 4 Feb 2025 12:48:57 +0000
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch,
	Alexander Duyck <alexanderduyck@...a.com>
Subject: Re: [PATCH net-next 2/2] eth: fbnic: set IFF_UNICAST_FLT to avoid
 enabling promiscuous mode when adding unicast addrs

On Mon, Feb 03, 2025 at 05:00:38PM -0800, Jakub Kicinski wrote:
> From: Alexander Duyck <alexanderduyck@...a.com>
> 
> I realized when we were adding unicast addresses we were enabling
> promiscous mode. I did a bit of digging and realized we had overlooked
> setting the driver private flag to indicate we supported unicast filtering.
> 
> Example below shows the table with 00deadbeef01 as the main NIC address,
> and 5 additional addresses in the 00deadbeefX0 format.
> 
>   # cat $dbgfs/mac_addr
>   Idx S TCAM Bitmap       Addr/Mask
>   ----------------------------------
>   00  0 00000000,00000000 000000000000
>                           000000000000
>   01  0 00000000,00000000 000000000000
>                           000000000000
>   02  0 00000000,00000000 000000000000
>                           000000000000
>   ...
>   24  0 00000000,00000000 000000000000
>                           000000000000
>   25  1 00100000,00000000 00deadbeef50
>                           000000000000
>   26  1 00100000,00000000 00deadbeef40
>                           000000000000
>   27  1 00100000,00000000 00deadbeef30
>                           000000000000
>   28  1 00100000,00000000 00deadbeef20
>                           000000000000
>   29  1 00100000,00000000 00deadbeef10
>                           000000000000
>   30  1 00100000,00000000 00deadbeef01
>                           000000000000
>   31  0 00000000,00000000 000000000000
>                           000000000000
> 
> Before rule 31 would be active. With this change it correctly sticks
> to just the unicast filters.
> 
> Signed-off-by: Alexander Duyck <alexanderduyck@...a.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>