netdev - Re: [PATCH net-next] s390/net: Remove LCS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250204143938.GE234677@kernel.org>
Date: Tue, 4 Feb 2025 14:39:38 +0000
From: Simon Horman <horms@...nel.org>
To: Alexandra Winter <wintera@...ux.ibm.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Aswin Karuvally <aswin@...ux.ibm.com>, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Jonathan Corbet <corbet@....net>,
	Peter Oberparleiter <oberpar@...ux.ibm.com>
Subject: Re: [PATCH net-next] s390/net: Remove LCS driver

On Tue, Feb 04, 2025 at 11:31:35AM +0100, Alexandra Winter wrote:
> From: Aswin Karuvally <aswin@...ux.ibm.com>
> 
> The original Open Systems Adapter (OSA) was introduced by IBM in the
> mid-90s. These were then superseded by OSA-Express in 1999 which used
> Queued Direct IO to greatly improve throughput. The newer cards
> retained the older, slower non-QDIO (OSE) modes for compatibility with
> older systems. In Linux, the lcs driver was responsible for cards
> operating in the older OSE mode and the qeth driver was introduced to
> allow the OSA-Express cards to operate in the newer QDIO (OSD) mode.
> 
> For an S390 machine from 1998 or later, there is no reason to use the
> OSE mode and lcs driver as all OSA cards since 1999 provide the faster
> OSD mode. As a result, it's been years since we have heard of a
> customer configuration involving the lcs driver.
> 
> This patch removes the lcs driver. The technology it supports has been
> obsolete for past 25+ years and is irrelevant for current use cases.
> 
> Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>
> Acked-by: Heiko Carstens <hca@...ux.ibm.com>
> Acked-by: Peter Oberparleiter <oberpar@...ux.ibm.com>
> Signed-off-by: Aswin Karuvally <aswin@...ux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>
> ---
>  Documentation/arch/s390/driver-model.rst |    2 +-
>  arch/s390/include/asm/irq.h              |    1 -
>  arch/s390/kernel/irq.c                   |    1 -
>  drivers/s390/net/Kconfig                 |   11 +-
>  drivers/s390/net/Makefile                |    1 -
>  drivers/s390/net/lcs.c                   | 2385 ----------------------
>  drivers/s390/net/lcs.h                   |  342 ----
>  7 files changed, 2 insertions(+), 2741 deletions(-)
>  delete mode 100644 drivers/s390/net/lcs.c
>  delete mode 100644 drivers/s390/net/lcs.h

Less is more :)

Reviewed-by: Simon Horman <horms@...nel.org>