netdev - Re: [PATCH net-next v3 04/10] net: pktgen: fix 'rate 0' error handling (return -EINVAL)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250204144407.GH234677@kernel.org>
Date: Tue, 4 Feb 2025 14:44:07 +0000
From: Simon Horman <horms@...nel.org>
To: Peter Seiderer <ps.report@....net>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Nam Cao <namcao@...utronix.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <frederic@...nel.org>,
	Artem Chernyshev <artem.chernyshev@...-soft.ru>
Subject: Re: [PATCH net-next v3 04/10] net: pktgen: fix 'rate 0' error
 handling (return -EINVAL)

On Mon, Feb 03, 2025 at 06:01:55PM +0100, Peter Seiderer wrote:
> Given an invalid 'rate' command e.g. 'rate 0' the return value is '1',
> leading to the following misleading output:
> 
> - the good case
> 
> 	$ echo "rate 100" > /proc/net/pktgen/lo\@0
> 	$ grep "Result:" /proc/net/pktgen/lo\@0
> 	Result: OK: rate=100
> 
> - the bad case (before the patch)
> 
> 	$ echo "rate 0" > /proc/net/pktgen/lo\@0"
> 	-bash: echo: write error: Invalid argument
> 	$ grep "Result:" /proc/net/pktgen/lo\@0
> 	Result: No such parameter "ate"
> 
> - with patch applied
> 
> 	$ echo "rate 0" > /proc/net/pktgen/lo\@0
> 	-bash: echo: write error: Invalid argument
> 	$ grep "Result:" /proc/net/pktgen/lo\@0
> 	Result: Idle
> 
> Signed-off-by: Peter Seiderer <ps.report@....net>

Reviewed-by: Simon Horman <horms@...nel.org>