netdev - Re: [PATCH net 2/2] MAINTAINERS: add a sample ethtool section entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <271b2d3b-6d46-437a-8fdb-f5d811943cb5@lunn.ch>
Date: Tue, 4 Feb 2025 17:12:22 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
	netdev@...r.kernel.org, edumazet@...gle.com, andrew+netdev@...n.ch,
	horms@...nel.org
Subject: Re: [PATCH net 2/2] MAINTAINERS: add a sample ethtool section entry

On Tue, Feb 04, 2025 at 07:37:59AM -0800, Jakub Kicinski wrote:
> On Tue, 4 Feb 2025 10:26:40 +0100 Paolo Abeni wrote:
> > On 2/2/25 3:11 AM, Jakub Kicinski wrote:
> > > This patch is a nop from process perspective, since Andrew already
> > > is a maintainer and reviews all this code. Let's focus on discussing
> > > merits of the "section entries" in abstract?  
> > 
> > Should the keyword be a little more generic, i.e. just 'cable_test'?
> > AFAICS the current one doesn't catch the device drivers,
> > 
> > I agree encouraging more driver API reviewer would be great, but I
> > personally have a slight preference to add/maintain entries only they
> > actually affect the process.
> 
> You're right, I was going after the op name. Seems like a good default
> keyword. But it appears that there are two layers of ops, one called
> start_cable_test and the next cable_test_start, so this isn't catching
> actual drivers.

https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/phy.h#L1080

The op in the driver structure is cable_test_start. There is also
cable_test_tdr_start but so far only Marvell hardware supports raw TDR
data. At the moment, cable_test_start does not produce any false
positives anywhere else in the kernel.

	Andrew