netdev - Re: [PATCH net-next] bonding: delete always true device check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66eeca24-0995-401f-8ca7-d0dbb86f6b7c@blackwall.org>
Date: Tue, 4 Feb 2025 18:38:56 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Leon Romanovsky <leon@...nel.org>, Jay Vosburgh <jv@...sburgh.net>
Cc: Leon Romanovsky <leonro@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Hangbin Liu <liuhangbin@...il.com>, Jakub Kicinski <kuba@...nel.org>,
 netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] bonding: delete always true device check

On 2/3/25 14:59, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> XFRM API makes sure that xs->xso.dev is valid in all XFRM offload
> callbacks. There is no need to check it again.
> 
> Fixes: 1ddec5d0eec4 ("bonding: add common function to check ipsec device")
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> ---
> There is nothing urgent in this change, it can go to net-next too.
> ---
>  drivers/net/bonding/bond_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index bfb55c23380b..154e670d8075 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -432,9 +432,6 @@ static struct net_device *bond_ipsec_dev(struct xfrm_state *xs)
>  	struct bonding *bond;
>  	struct slave *slave;
>  
> -	if (!bond_dev)
> -		return NULL;
> -
>  	bond = netdev_priv(bond_dev);
>  	if (BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP)
>  		return NULL;

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>