netdev - Re: [PATCH net-next] bridge: mdb: Allow replace of a host-joined group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f50c11c3-8619-4491-8607-c58867d01deb@blackwall.org>
Date: Tue, 4 Feb 2025 20:08:04 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org
Cc: Roopa Prabhu <roopa@...dia.com>, Ido Schimmel <idosch@...dia.com>,
 bridge@...ts.linux.dev, mlxsw@...dia.com
Subject: Re: [PATCH net-next] bridge: mdb: Allow replace of a host-joined
 group

On 2/4/25 19:37, Petr Machata wrote:
> Attempts to replace an MDB group membership of the host itself are
> currently bounced:
> 
>  # ip link add name br up type bridge vlan_filtering 1
>  # bridge mdb replace dev br port br grp 239.0.0.1 vid 2
>  # bridge mdb replace dev br port br grp 239.0.0.1 vid 2
>  Error: bridge: Group is already joined by host.
> 
> A similar operation done on a member port would succeed. Ignore the check
> for replacement of host group memberships as well.
> 
> The bit of code that this enables is br_multicast_host_join(), which, for
> already-joined groups only refreshes the MC group expiration timer, which
> is desirable; and a userspace notification, also desirable.
> 
> Change a selftest that exercises this code path from expecting a rejection
> to expecting a pass. The rest of MDB selftests pass without modification.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/bridge/br_mdb.c                                  | 2 +-
>  tools/testing/selftests/net/forwarding/bridge_mdb.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>