netdev - Re: [PATCH net 1/2] vsock: Orphan socket after transport release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3dcc1801-a256-4a72-8371-1f06b57cef86@rbox.co>
Date: Wed, 5 Feb 2025 00:59:29 +0100
From: Michal Luczaj <mhal@...x.co>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org, syzbot+9d55b199192a4be7d02c@...kaller.appspotmail.com
Subject: Re: [PATCH net 1/2] vsock: Orphan socket after transport release

On 2/4/25 11:32, Stefano Garzarella wrote:
> On Tue, Feb 04, 2025 at 01:29:52AM +0100, Michal Luczaj wrote:
>> @@ -824,13 +824,14 @@ static void __vsock_release(struct sock *sk, int level)
>> 	 */
>> 	lock_sock_nested(sk, level);
>>
> 
> I would add a comment here to explain that we need to set it, so 
> vsock_remove_sock() called here some lines above, or by transports in 
> the release() callback (maybe in the future we can refactor it, and call 
> it only here) will remove the binding only if it's set, since the 
> release() is also called when de-assigning the transport.
> 
>> -	sock_orphan(sk);
>> +	sock_set_flag(sk, SOCK_DEAD);

OK, will do.

Thanks,
Michal