netdev - Re: [PATCH ethtool-next v3 10/16] qsfp: Add JSON output handling to --module-info in SFF8636 modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c417b93-773b-432b-89f6-fe380ca4878f@linux.dev>
Date: Wed, 5 Feb 2025 12:20:01 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Danielle Ratson <danieller@...dia.com>, Jakub Kicinski <kuba@...nel.org>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "mkubecek@...e.cz" <mkubecek@...e.cz>,
 "matt@...verse.com.au" <matt@...verse.com.au>,
 "daniel.zahka@...il.com" <daniel.zahka@...il.com>,
 Amit Cohen <amcohen@...dia.com>, NBU-mlxsw <NBU-mlxsw@...hange.nvidia.com>
Subject: Re: [PATCH ethtool-next v3 10/16] qsfp: Add JSON output handling to
 --module-info in SFF8636 modules

On 05/02/2025 12:13, Danielle Ratson wrote:
>> From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
>> Sent: Wednesday, 5 February 2025 12:48
>> To: Jakub Kicinski <kuba@...nel.org>; Danielle Ratson <danieller@...dia.com>
>> Cc: netdev@...r.kernel.org; mkubecek@...e.cz; matt@...verse.com.au;
>> daniel.zahka@...il.com; Amit Cohen <amcohen@...dia.com>; NBU-mlxsw
>> <nbu-mlxsw@...hange.nvidia.com>
>> Subject: Re: [PATCH ethtool-next v3 10/16] qsfp: Add JSON output handling
>> to --module-info in SFF8636 modules
>>
>> On 05/02/2025 02:34, Jakub Kicinski wrote:
>>> On Tue, 4 Feb 2025 15:39:51 +0200 Danielle Ratson wrote:
>>>> +#define YESNO(x) (((x) != 0) ? "Yes" : "No") #define ONOFF(x) (((x)
>>>> +!= 0) ? "On" : "Off")
>>>
>>> Are these needed ? It appears we have them defined twice after this
>>> series:
>>>
>>> $ git grep 'define YES'
>>> cmis.h:#define YESNO(x) (((x) != 0) ? "Yes" : "No")
>>> module-common.h:#define YESNO(x) (((x) != 0) ? "Yes" : "No")
>>
>> Are we strict on capital first letter here? If not then maybe try to use
>> str_yes_no() and remove this definition completely?
> 
> I only moved it to a different file, I didn’t find a reason to change it right now.
> I can add a separate patch to change all the YESNO and ONOFF uses, and remove those definitions, do you want me to do that?
> To be honest, I don’t know if there is a justification to do it in that patchset, considering it is a pretty long anyway.

Well, I do really know that pure refactoring to str_yes_no() and
str_on_off() are not appreciated in netdev. I thought that we may
combine these changes, but no strong feeling. We may keep it as is.