netdev - Re: [PATCH net-next 3/3] net: dsa: mt7530: convert to phylink managed EEE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10de11cf-a443-472e-aaec-df9e2ed54090@arinc9.com>
Date: Wed, 05 Feb 2025 15:42:30 +0000 (UTC)
From: "Chester A. Unal" <chester.a.unal@...nc9.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Daniel Golle <daniel@...rotopia.org>, "David S. Miller"
 <davem@...emloft.net>, DENG Qingfang <dqfext@...il.com>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Matthias Brugger <matthias.bgg@...il.com>, netdev@...r.kernel.org,
 Paolo Abeni <pabeni@...hat.com>, Sean Wang <sean.wang@...iatek.com>,
 Simon Horman <horms@...nel.org>, Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 3/3] net: dsa: mt7530: convert to phylink managed
 EEE

Hello Russell.

On 05/02/2025 15:11, Russell King (Oracle) wrote:
> Fixme: doesn't bit 25 and 26 also need to be set in the PMCR for
> PMCR_FORCE_EEE100 and PMCR_FORCE_EEE1G to take effect?

Yes, but only for MT7531 and the switch component of the MT7988 SoC. For
MT7530 and the switch component of the AN7581 SoC, bit 15
(MT7530_FORCE_MODE) must be set. The MT753X DSA subdriver sets these bits
accordingly at the setup function that pertains to the specific switch
model.

Chester A.