netdev - Re: [PATCH net-next 4/4] eth: mlx4: use the page pool for Rx buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6OoZwJ-REpisYb6@shredder>
Date: Wed, 5 Feb 2025 20:05:27 +0200
From: Ido Schimmel <idosch@...sch.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	tariqt@...dia.com, hawk@...nel.org
Subject: Re: [PATCH net-next 4/4] eth: mlx4: use the page pool for Rx buffers

On Tue, Feb 04, 2025 at 07:12:13PM -0800, Jakub Kicinski wrote:
> @@ -283,6 +265,7 @@ int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,
>  	pp.netdev = priv->dev;
>  	pp.dev = &mdev->dev->persist->pdev->dev;
>  	pp.dma_dir = DMA_BIDIRECTIONAL;
> +	pp.max_len = PAGE_SIZE;

Possibly a stupid question, but can you explain this hunk given patch #1
does not set 'PP_FLAG_DMA_SYNC_DEV' ?