[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <67a3c49e1a6ef_2d2c29487@dwillia2-xfh.jf.intel.com.notmuch>
Date: Wed, 5 Feb 2025 12:05:50 -0800
From: Dan Williams <dan.j.williams@...el.com>
To: Dan Williams <dan.j.williams@...el.com>, Alejandro Lucero Palau
<alucerop@....com>, <alejandro.lucero-palau@....com>,
<linux-cxl@...r.kernel.org>, <netdev@...r.kernel.org>,
<martin.habets@...inx.com>, <edward.cree@....com>, <davem@...emloft.net>,
<kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
<dave.jiang@...el.com>
Subject: Re: [PATCH v8 01/27] cxl: add type2 device basic support
Dan Williams wrote:
[..]
> I think there is a benefit from a driver being able to do someting like:
>
> struct my_cxl_accelerator_context {
> ...
> struct cxl_dev_state cxlds;
> ...
> };
>
> Even if the rule is that direct consumption of 'struct cxl_dev_state'
> outside of the cxl core is unwanted.
>
> C does not make this easy, so it is either make the definition of
> 'struct cxl_dev_state' public to CXL accelerator drivers so that they
> know the size, or add an allocation API that takes in the extra size
> that accelerator needs to allocate the core CXL context.
Jason has a novel approach to this problem of defining an allocation
interface that lets the caller register a caller provided data structure
that wraps a core internal object. Have a look at fwctl_alloc_device()
for inspiration:
http://lore.kernel.org/1-v3-960f17f90f17+516-fwctl_jgg@nvidia.com
Powered by blists - more mailing lists