netdev - Re: [PATCH v10 07/26] cxl: add support for setting media ready by an accel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67a3db2f253ed_2ee27529470@iweiny-mobl.notmuch>
Date: Wed, 5 Feb 2025 15:42:07 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: <alucerop@....com>, <linux-cxl@...r.kernel.org>, <netdev@...r.kernel.org>,
	<dan.j.williams@...el.com>, <edward.cree@....com>, <davem@...emloft.net>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<dave.jiang@...el.com>
CC: Alejandro Lucero <alucerop@....com>
Subject: Re: [PATCH v10 07/26] cxl: add support for setting media ready by an
 accel driver

alucerop@ wrote:
> From: Alejandro Lucero <alucerop@....com>

[snip]

> diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
> index 08705c39721d..4461cababf6a 100644
> --- a/drivers/cxl/core/pci.c
> +++ b/drivers/cxl/core/pci.c
> @@ -177,8 +177,9 @@ static int cxl_dvsec_mem_range_active(struct cxl_dev_state *cxlds, int id)
>   * Wait up to @media_ready_timeout for the device to report memory
>   * active.
>   */
> -int cxl_await_media_ready(struct cxl_dev_state *cxlds)
> +int cxl_await_media_ready(struct cxl_memdev_state *cxlmds)
>  {
> +	struct cxl_dev_state *cxlds = &cxlmds->cxlds;

I feel like I have missed something where suddenly cxl_memdev_state is the
primary carrier of the CXL state for accelerators.  Here, like in a
previous patch, you simply turn mds into cxlds?

>  	struct pci_dev *pdev = to_pci_dev(cxlds->dev);
>  	int d = cxlds->cxl_dvsec;
>  	int rc, i, hdm_count;
> @@ -211,6 +212,14 @@ int cxl_await_media_ready(struct cxl_dev_state *cxlds)
>  }
>  EXPORT_SYMBOL_NS_GPL(cxl_await_media_ready, "CXL");
>  
> +void cxl_set_media_ready(struct cxl_memdev_state *cxlmds)
> +{
> +	struct cxl_dev_state *cxlds = &cxlmds->cxlds;

And here same thing here?

Ira

[snip]