netdev - Re: [PATCH v10 15/26] sfc: obtain root decoder with enough HPA free space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67a3ea6d8432e_2ee27529434@iweiny-mobl.notmuch>
Date: Wed, 5 Feb 2025 16:47:09 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: <alucerop@....com>, <linux-cxl@...r.kernel.org>, <netdev@...r.kernel.org>,
	<dan.j.williams@...el.com>, <edward.cree@....com>, <davem@...emloft.net>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<dave.jiang@...el.com>
CC: Alejandro Lucero <alucerop@....com>
Subject: Re: [PATCH v10 15/26] sfc: obtain root decoder with enough HPA free
 space

alucerop@ wrote:
> From: Alejandro Lucero <alucerop@....com>

[snip]

> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> index 774e1cb4b1cb..a9ff84143e5d 100644
> --- a/drivers/net/ethernet/sfc/efx_cxl.c
> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> @@ -25,6 +25,7 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  	struct pci_dev *pci_dev = efx->pci_dev;
>  	DECLARE_BITMAP(expected, CXL_MAX_CAPS);
>  	DECLARE_BITMAP(found, CXL_MAX_CAPS);
> +	resource_size_t max_size;
>  	struct mds_info sfc_mds_info;
>  	struct efx_cxl *cxl;
>  
> @@ -102,6 +103,24 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  		goto err_regs;
>  	}
>  
> +	cxl->cxlrd = cxl_get_hpa_freespace(cxl->cxlmd, 1,
> +					   CXL_DECODER_F_RAM | CXL_DECODER_F_TYPE2,

Won't the addition of CXL_DECODER_F_TYPE2 cause this to fail?  I'm not
seeing CXL_DECODER_F_TYPE2 set on a decoder in any of the patches.  So
won't that make the flags check fail?  Why is CXL_DECODER_F_RAM not
enough?

Ira

[snip]