netdev - Re: [PATCH bpf-next v3 08/18] bpf: net_sched: Support implementation of Qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMB2axMrKN_2=o+SRAvh_cBkc347JVhZE4OgojH=vUyV_cBGOA@mail.gmail.com>
Date: Tue, 4 Feb 2025 20:13:07 -0800
From: Amery Hung <ameryhung@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, daniel@...earbox.net, 
	andrii@...nel.org, alexei.starovoitov@...il.com, martin.lau@...nel.org, 
	edumazet@...gle.com, xiyou.wangcong@...il.com, cong.wang@...edance.com, 
	jhs@...atatu.com, sinquersw@...il.com, toke@...hat.com, jiri@...nulli.us, 
	stfomichev@...il.com, ekarani.silvestre@....ufcg.edu.br, 
	yangpeihao@...u.edu.cn, yepeilin.cs@...il.com, ming.lei@...hat.com, 
	kernel-team@...a.com
Subject: Re: [PATCH bpf-next v3 08/18] bpf: net_sched: Support implementation
 of Qdisc_ops in bpf

On Tue, Feb 4, 2025 at 5:27 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 4 Feb 2025 15:21:27 -0800 Amery Hung wrote:
> > On Tue, Feb 4, 2025 at 2:18 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > > On Fri, 31 Jan 2025 11:28:47 -0800 Amery Hung wrote:
> > > > +             if (new &&
> > > > +                 !(parent->flags & TCQ_F_MQROOT) &&
> > > > +                 new->ops->owner == BPF_MODULE_OWNER) {
> > > > +                     NL_SET_ERR_MSG(extack, "BPF qdisc not supported on a non root");
> > > > +                     return -EINVAL;
> > > > +             }
> > >
> > > This check should live in bpf_qdisc.c
> >
> > Might be a dumb question, but could you explain why this is preferred?
> >
> > I can certainly do the check in Qdisc_ops::init instead though.
>
> Basic SW abstractions, this is the generic layer, bpf_qdisc is just
> one implementation that plugs into it.

Got it. Thanks for the clarification.