netdev - Re: [PATCH net-next 2/9] ice: devlink PF MSI-X max and min parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6L7Tc/PHmCptobX@mev-dev.igk.intel.com>
Date: Wed, 5 Feb 2025 06:46:53 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
	pabeni@...hat.com, edumazet@...gle.com, andrew+netdev@...n.ch,
	netdev@...r.kernel.org, sridhar.samudrala@...el.com,
	jacob.e.keller@...el.com, pio.raczynski@...il.com,
	konrad.knitter@...el.com, marcin.szycik@...el.com,
	nex.sw.ncis.nat.hpm.dev@...el.com, przemyslaw.kitszel@...el.com,
	jiri@...nulli.us, horms@...nel.org, David.Laight@...lab.com,
	pmenzel@...gen.mpg.de, mschmidt@...hat.com,
	tatyana.e.nikolova@...el.com, Jason Gunthorpe <jgg@...pe.ca>,
	Leon Romanovsky <leon@...nel.org>, linux-rdma@...r.kernel.org,
	corbet@....net, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next 2/9] ice: devlink PF MSI-X max and min parameter

On Tue, Feb 04, 2025 at 02:35:17PM -0800, Jakub Kicinski wrote:
> On Mon,  3 Feb 2025 13:09:31 -0800 Tony Nguyen wrote:
> > +	if (val.vu32 > pf->hw.func_caps.common_cap.num_msix_vectors ||
> > +	    val.vu32 < pf->msix.min) {
> > +		NL_SET_ERR_MSG_MOD(extack, "Value is invalid");
> > +		return -EINVAL;
> 
> > +	if (val.vu32 < ICE_MIN_MSIX || val.vu32 > pf->msix.max) {
> > +		NL_SET_ERR_MSG_MOD(extack, "Value is invalid");
> > +		return -EINVAL;
> 
> Please follow up and either remove these extack messages, or make them
> more meaningful. The "value is invalid" is already expressed by EINVAL

Will be removed.

> 
> The suggestion to set the values at once or as "pending" is a
> distraction IMO.