netdev - Re: [PATCH net-next] tools: ynl: add all headers to makefile deps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD4GDZxO8O4L1Zj2gSXZp9utSmKTE4_6AegTKEf=9vqN697-2g@mail.gmail.com>
Date: Thu, 6 Feb 2025 08:54:46 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	danieller@...dia.com, sdf@...ichev.me
Subject: Re: [PATCH net-next] tools: ynl: add all headers to makefile deps

On Wed, 5 Feb 2025 at 17:33, Jakub Kicinski <kuba@...nel.org> wrote:
>
> The Makefile.deps lists uAPI headers to make the build work when
> system headers are older than in-tree headers. The problem doesn't
> occur for new headers, because system headers are not there at all.
> But out-of-tree YNL clone on GH also uses this header to identify
> header dependencies, and one day the system headers will exist,
> and will get out of date. So let's add the headers we missed.
>
> I don't think this is a fix, but FWIW the commits which added
> the missing headers are:
>
> commit 04e65df94b31 ("netlink: spec: add shaper YAML spec")
> commit 49922401c219 ("ethtool: separate definitions that are gonna be generated")
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>