netdev - Re: [PATCH net-next, v7 2/2] selftests/net: Add selftest for IPv4 RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c11113e-c7d0-4c71-9f5c-02e7a90940fe@redhat.com>
Date: Thu, 6 Feb 2025 15:23:48 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Yuyang Huang <yuyanghuang@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>,
 netdev@...r.kernel.org, Donald Hunter <donald.hunter@...il.com>,
 Shuah Khan <shuah@...nel.org>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Hangbin Liu <liuhangbin@...il.com>, Daniel Borkmann <daniel@...earbox.net>,
 linux-kselftest@...r.kernel.org, Maciej Żenczykowski
 <maze@...gle.com>, Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH net-next, v7 2/2] selftests/net: Add selftest for IPv4
 RTM_GETMULTICAST support

On 2/4/25 10:19 AM, Yuyang Huang wrote:
> diff --git a/tools/testing/selftests/net/lib/py/ynl.py b/tools/testing/selftests/net/lib/py/ynl.py
> index ad1e36baee2a..7b1e29467e46 100644
> --- a/tools/testing/selftests/net/lib/py/ynl.py
> +++ b/tools/testing/selftests/net/lib/py/ynl.py
> @@ -38,8 +38,8 @@ class EthtoolFamily(YnlFamily):
>  
>  
>  class RtnlFamily(YnlFamily):
> -    def __init__(self, recv_size=0):
> -        super().__init__((SPEC_PATH / Path('rt_link.yaml')).as_posix(),
> +    def __init__(self, recv_size=0, spec='rt_link.yaml'):
> +        super().__init__((SPEC_PATH / Path(spec)).as_posix(),
>                           schema='', recv_size=recv_size)

The preferred way of handling this case is to define a new class, still
derived from YnlFamily, setting the correct path in the constructor.

/P