netdev - Re: [PATCH net-next, v7 1/2] netlink: support dumping IPv4 multicast addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADXeF1H32H=SsMUM7DgA=v9utzhnWfpPhKu5wouriOkTCtVUnw@mail.gmail.com>
Date: Fri, 7 Feb 2025 01:00:40 +0900
From: Yuyang Huang <yuyanghuang@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>, 
	netdev@...r.kernel.org, Donald Hunter <donald.hunter@...il.com>, 
	Shuah Khan <shuah@...nel.org>, Nikolay Aleksandrov <razor@...ckwall.org>, 
	Hangbin Liu <liuhangbin@...il.com>, Daniel Borkmann <daniel@...earbox.net>, 
	linux-kselftest@...r.kernel.org, Maciej Żenczykowski <maze@...gle.com>, 
	Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH net-next, v7 1/2] netlink: support dumping IPv4 multicast addresses

>I did not undertand you intended to place the new header under the
>'include' directory. I still have a preference for a really private
>header that would under 'net/ipv4/' (IMHO the possible future divergence
>of inet_fill_args and inet6_fill_args is not very relevant) but it's not
>a deal breaker.

Thanks for the advice, I will move the header file under 'net/ipv4' in
the next version of this patch.

Thanks,

Yuyang

On Thu, Feb 6, 2025 at 11:29 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 2/4/25 10:19 AM, Yuyang Huang wrote:
> > diff --git a/include/linux/igmp_internal.h b/include/linux/igmp_internal.h
> > new file mode 100644
> > index 000000000000..0a1bcc8ec8e1
> > --- /dev/null
> > +++ b/include/linux/igmp_internal.h
>
> I did not undertand you intended to place the new header under the
> 'include' directory. I still have a preference for a really private
> header that would under 'net/ipv4/' (IMHO the possible future divergence
> of inet_fill_args and inet6_fill_args is not very relevant) but it's not
> a deal breaker.
>
> /P
>