netdev - Re: [PATCH net-next] net: renesas: rswitch: Convert to for_each_available_child_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250206163126.GY554665@kernel.org>
Date: Thu, 6 Feb 2025 16:31:26 +0000
From: Simon Horman <horms@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Nikita Yushchenko <nikita.yoush@...entembedded.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH net-next] net: renesas: rswitch: Convert to
 for_each_available_child_of_node()

On Wed, Feb 05, 2025 at 05:18:14PM +0100, Geert Uytterhoeven wrote:
> Hi Nikita,
> 
> On Wed, 5 Feb 2025 at 17:15, Nikita Yushchenko
> <nikita.yoush@...entembedded.com> wrote:
> > > Simplify rswitch_get_port_node() by using the
> > > for_each_available_child_of_node() helper instead of manually ignoring
> > > unavailable child nodes, and leaking a reference.
> >
> > FYI, I have a patch in my queue that replaces this code with traversing child nodes (via
> > for_each_available_child_of_node()) and only creating devices for ports actually defined in the device tree.
> 
> OK, thanks for letting me know!

I am assuming that we can treat Nikita's patch as being orthogonal to this one.

Reviewed-by: Simon Horman <horms@...nel.org>