netdev - Re: [PATCH v10 05/26] cxl: add function for type2 cxl regs setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cb382e2-2ed0-41f9-976b-e5037a65dddb@amd.com>
Date: Thu, 6 Feb 2025 17:50:47 +0000
From: Alejandro Lucero Palau <alucerop@....com>
To: Ira Weiny <ira.weiny@...el.com>, linux-cxl@...r.kernel.org,
 netdev@...r.kernel.org, dan.j.williams@...el.com, edward.cree@....com,
 davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, dave.jiang@...el.com
Subject: Re: [PATCH v10 05/26] cxl: add function for type2 cxl regs setup


On 2/5/25 21:35, Ira Weiny wrote:
> alucerop@ wrote:
>> From: Alejandro Lucero <alucerop@....com>
> [snip]
>
>> +
>> +int cxl_pci_accel_setup_regs(struct pci_dev *pdev, struct cxl_memdev_state *cxlmds,
>> +			      unsigned long *caps)
>> +{
>> +	struct cxl_dev_state *cxlds = &cxlmds->cxlds;
> Isn't it odd that cxl_memdev_state is passed here only to be turned into
> what you really need, cxl_dev_state?
>
> Ira
>
>
> [snip]


Yes. The only explanation is to keep calls in the accel API orthogonal 
always using cxl_memdev_state now.


The interesting part comes later in other of your reviews.