| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202502070610.tbfoIwkS-lkp@intel.com>
Date: Fri, 7 Feb 2025 07:06:33 +0800
From: kernel test robot <lkp@...el.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Felix Fietkau <nbd@....name>, Sean Wang <sean.wang@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
upstream@...oha.com
Subject: Re: [PATCH net-next 10/13] net: airoha: Introduce PPE initialization
via NPU
Hi Lorenzo,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 135c3c86a7cef4ba3d368da15b16c275b74582d3]
url: https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Bianconi/net-airoha-Move-airoha_eth-driver-in-a-dedicated-folder/20250206-022555
base: 135c3c86a7cef4ba3d368da15b16c275b74582d3
patch link: https://lore.kernel.org/r/20250205-airoha-en7581-flowtable-offload-v1-10-d362cfa97b01%40kernel.org
patch subject: [PATCH net-next 10/13] net: airoha: Introduce PPE initialization via NPU
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20250207/202502070610.tbfoIwkS-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250207/202502070610.tbfoIwkS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502070610.tbfoIwkS-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/devcoredump.h:8,
from drivers/net/ethernet/airoha/airoha_npu.c:7:
drivers/net/ethernet/airoha/airoha_npu.c: In function 'airoha_npu_run_firmware':
>> drivers/net/ethernet/airoha/airoha_npu.c:200:30: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
200 | dev_err(dev, "%s: fw size too overlimit (%ld)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/net/ethernet/airoha/airoha_npu.c:200:17: note: in expansion of macro 'dev_err'
200 | dev_err(dev, "%s: fw size too overlimit (%ld)\n",
| ^~~~~~~
drivers/net/ethernet/airoha/airoha_npu.c:200:60: note: format string is defined here
200 | dev_err(dev, "%s: fw size too overlimit (%ld)\n",
| ~~^
| |
| long int
| %d
drivers/net/ethernet/airoha/airoha_npu.c:220:30: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
220 | dev_err(dev, "%s: fw size too overlimit (%ld)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/net/ethernet/airoha/airoha_npu.c:220:17: note: in expansion of macro 'dev_err'
220 | dev_err(dev, "%s: fw size too overlimit (%ld)\n",
| ^~~~~~~
drivers/net/ethernet/airoha/airoha_npu.c:220:60: note: format string is defined here
220 | dev_err(dev, "%s: fw size too overlimit (%ld)\n",
| ~~^
| |
| long int
| %d
vim +200 drivers/net/ethernet/airoha/airoha_npu.c
187
188 static int airoha_npu_run_firmware(struct airoha_npu *npu, struct reserved_mem *rmem)
189 {
190 struct device *dev = &npu->pdev->dev;
191 const struct firmware *fw;
192 void __iomem *addr;
193 int ret;
194
195 ret = request_firmware(&fw, NPU_EN7581_FIRMWARE_RV32, dev);
196 if (ret)
197 return ret;
198
199 if (fw->size > NPU_EN7581_FIRMWARE_RV32_MAX_SIZE) {
> 200 dev_err(dev, "%s: fw size too overlimit (%ld)\n",
201 NPU_EN7581_FIRMWARE_RV32, fw->size);
202 ret = -E2BIG;
203 goto out;
204 }
205
206 addr = devm_ioremap(dev, rmem->base, rmem->size);
207 if (!addr) {
208 ret = -ENOMEM;
209 goto out;
210 }
211
212 memcpy_toio(addr, fw->data, fw->size);
213 release_firmware(fw);
214
215 ret = request_firmware(&fw, NPU_EN7581_FIRMWARE_DATA, dev);
216 if (ret)
217 return ret;
218
219 if (fw->size > NPU_EN7581_FIRMWARE_DATA_MAX_SIZE) {
220 dev_err(dev, "%s: fw size too overlimit (%ld)\n",
221 NPU_EN7581_FIRMWARE_DATA, fw->size);
222 ret = -E2BIG;
223 goto out;
224 }
225
226 memcpy_toio(npu->base + REG_NPU_LOCAL_SRAM, fw->data, fw->size);
227 out:
228 release_firmware(fw);
229
230 return ret;
231 }
232
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists