netdev - Re: [PATCH bpf-next v8 10/12] bpf: make TCP tx timestamp bpf extension work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67a42ba112990_19c315294b7@willemb.c.googlers.com.notmuch>
Date: Wed, 05 Feb 2025 22:25:21 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jason Xing <kerneljasonxing@...il.com>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Martin KaFai Lau <martin.lau@...ux.dev>, 
 Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 dsahern@...nel.org, 
 willemb@...gle.com, 
 ast@...nel.org, 
 daniel@...earbox.net, 
 andrii@...nel.org, 
 eddyz87@...il.com, 
 song@...nel.org, 
 yonghong.song@...ux.dev, 
 john.fastabend@...il.com, 
 kpsingh@...nel.org, 
 sdf@...ichev.me, 
 haoluo@...gle.com, 
 jolsa@...nel.org, 
 horms@...nel.org, 
 bpf@...r.kernel.org, 
 netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v8 10/12] bpf: make TCP tx timestamp bpf
 extension work

> > > I think we can split the whole idea into two parts: for now, because
> > > of the current series implementing the same function as SO_TIMETAMPING
> > > does, I will implement the selective sample feature in the series.
> > > After someday we finish tracing all the skb, then we will add the
> > > corresponding selective sample feature.
> >
> > Are you saying that you will include selective sampling now or want to
> > postpone it?
> 
> A few months ago, I planned to do it after this series. Since you all
> ask, it's not complex to have it included in this series :)
> 
> Selective sampling has two kinds of meaning like I mentioned above, so
> in the next re-spin I will implement the cmsg feature for bpf
> extension in this series. 

Great thanks.

> I'm doing the test right now. And leave
> another selective sampling small feature until the feature of tracing
> all the skbs is implemented if possible.

Can you elaborate on this other feature?
 
> >
> > Jakub brought up a great point. Our continuous deployment would not be
> > feasible without sampling. Indeed implemented using cmsg.
> 
> Right, right. I just realized that I misunderstood what Jakub offered.
> 
> >
> > I think it should be included from the initial patch series.
> 
> I agree to include this in this series. Like what I wrote in the
> previous thread, it should be simple :) And it will be manifested in
> the selftests as well.
> 
> Thanks,
> Jason