netdev - Re: [PATCH v2 net-next 8/8] net: fib_rules: Convert RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL+yp_hN0sm6Uavivem63zbCrehzUvBd6dbhhhRRsbLWg@mail.gmail.com>
Date: Fri, 7 Feb 2025 09:36:50 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Ido Schimmel <idosch@...sch.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 8/8] net: fib_rules: Convert RTM_DELRULE to
 per-netns RTNL.

On Fri, Feb 7, 2025 at 8:28 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> fib_nl_delrule() is the doit() handler for RTM_DELRULE but also called
> from vrf_newlink() in case something fails in vrf_add_fib_rules().
>
> In the latter case, RTNL is already held and the 4th arg is true.
>
> Let's hold per-netns RTNL in fib_delrule() if rtnl_held is false.
>
> Now we can place ASSERT_RTNL_NET() in call_fib_rule_notifiers().
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>