netdev - Re: [PATCH net-next 2/2] net: mctp: Add MCTP USB transport driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <912d59eb611448ed9da16ef82b79f77d6fa0c654.camel@codeconstruct.com.au>
Date: Fri, 07 Feb 2025 16:49:05 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Matt Johnston <matt@...econstruct.com.au>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-usb@...r.kernel.org,  Santosh Puranik <spuranik@...dia.com>
Subject: Re: [PATCH net-next 2/2] net: mctp: Add MCTP USB transport driver

Hi Greg,

Just a check here:

> > +               dev_err(&mctp_usb->usbdev->dev, "%s: urb status: %d\n",
> > +                       __func__, status);
> 
> This could flood the logs, are you sure you need it at dev_err()
> level?
> 
> And __func__ is redundant, it's present in dev_*() calls already.

am I missing something then?

   [  146.130170] usb 2-1: short packet (hdr) 6

emitted from:

    dev_dbg(&mctp_usb->usbdev->dev,
            "short packet (hdr) %d\n",
            hdr->len);

Seems like we get the driver name, but not the function.

I'm happy to remove the __func__ output either way, but I will also
make the logs a little more descriptive for context, if we don't have
func data.

Cheers,

Jeremy