netdev - Re: [PATCH v4 04/10] taint: Add TAINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250207130943.00005b53@huawei.com>
Date: Fri, 7 Feb 2025 13:09:43 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: Andy Gospodarek <andrew.gospodarek@...adcom.com>, Aron Silverton
	<aron.silverton@...cle.com>, Dan Williams <dan.j.williams@...el.com>, Daniel
 Vetter <daniel.vetter@...ll.ch>, Dave Jiang <dave.jiang@...el.com>, David
 Ahern <dsahern@...nel.org>, Andy Gospodarek <gospo@...adcom.com>, Christoph
 Hellwig <hch@...radead.org>, Itay Avraham <itayavr@...dia.com>, Jiri Pirko
	<jiri@...dia.com>, Jakub Kicinski <kuba@...nel.org>, Leonid Bloch
	<lbloch@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
	<linux-cxl@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<netdev@...r.kernel.org>, Saeed Mahameed <saeedm@...dia.com>, "Nelson,
 Shannon" <shannon.nelson@....com>
Subject: Re: [PATCH v4 04/10] taint: Add TAINT_FWCTL

On Thu,  6 Feb 2025 20:13:26 -0400
Jason Gunthorpe <jgg@...dia.com> wrote:

> Requesting a fwctl scope of access that includes mutating device debug
> data will cause the kernel to be tainted. Changing the device operation
> through things in the debug scope may cause the device to malfunction in
> undefined ways. This should be reflected in the TAINT flags to help any
> debuggers understand that something has been done.
> 
> Signed-off-by: Jason Gunthorpe <jgg@...dia.com>
Not something I've ever directly touched before, so more eyes on this
would be good, but FWIW looks inline with other flags and the
general principle seems sensible to me.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>