netdev - Re: igb: XDP/ZC busy polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6YJ_LUD5Gpyb-at@LQ3V64L9R2>
Date: Fri, 7 Feb 2025 05:26:20 -0800
From: Joe Damato <jdamato@...tly.com>
To: Kurt Kanzenbach <kurt@...utronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	intel-wired-lan@...ts.osuosl.org
Subject: Re: igb: XDP/ZC busy polling

On Fri, Feb 07, 2025 at 09:38:41AM +0100, Kurt Kanzenbach wrote:
> Hello Joe,
> 
> I noticed that XDP/ZC busy polling does not work anymore in combination
> with igb driver. This seems to be related to commit 5ef44b3cb43b ("xsk:
> Bring back busy polling support") which relies on
> netif_queue_set_napi().
> 
> I see you implemented it for e1000, igc and so on. However, igb is
> missing. Do you have any plans to add the missing registration to igb?
> Just asking. Otherwise, I can send a patch for it.

Please feel free; I don't have an igb device so I wouldn't be able
to test it, but I'd happily review it so please CC me.

BTW, I wrote a small series that updates the documentation and adds
a test for AF_XDP [1] that you may want to consider applying/running
(if it is not merged by the time you add support to igb).

[1]: https://lore.kernel.org/lkml/20250207030916.32751-1-jdamato@fastly.com/