netdev - Re: [PATCH net-next v2 1/2] ethtool: Symmetric OR-XOR RSS hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250206173142.79a9ef3c@kernel.org>
Date: Thu, 6 Feb 2025 17:31:42 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "Tariq
 Toukan" <tariqt@...dia.com>, Edward Cree <ecree.xilinx@...il.com>, Ahmed
 Zaki <ahmed.zaki@...el.com>, <linux-doc@...r.kernel.org>, Cosmin Ratiu
 <cratiu@...dia.com>
Subject: Re: [PATCH net-next v2 1/2] ethtool: Symmetric OR-XOR RSS hash

On Wed, 5 Feb 2025 15:53:40 +0200 Gal Pressman wrote:
> @@ -997,7 +996,7 @@ struct kernel_ethtool_ts_info {
>  struct ethtool_ops {
>  	u32     cap_link_lanes_supported:1;
>  	u32     cap_rss_ctx_supported:1;
> -	u32	cap_rss_sym_xor_supported:1;
> +	u32	supported_input_xfrm:8;
>  	u32	rxfh_per_ctx_key:1;
>  	u32	cap_rss_rxnfc_adds:1;
>  	u32	rxfh_indir_space;

reorder the fields, please, so the 8b one is aligned to a byte