netdev - Re: [PATCH net 1/8] ndisc: ndisc_send_redirect() must use dev_get_by_index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0dbc9e6-ca5d-41e1-ac98-855c3cfdaa59@kernel.org>
Date: Fri, 7 Feb 2025 13:41:27 -0700
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Kuniyuki Iwashima <kuniyu@...zon.com>,
 Simon Horman <horms@...nel.org>, eric.dumazet@...il.com,
 Stephen Suryaputra <ssuryaextr@...il.com>
Subject: Re: [PATCH net 1/8] ndisc: ndisc_send_redirect() must use
 dev_get_by_index_rcu()

On 2/7/25 6:58 AM, Eric Dumazet wrote:
> ndisc_send_redirect() is called under RCU protection, not RTNL.
> 
> It must use dev_get_by_index_rcu() instead of __dev_get_by_index()
> 
> Fixes: 2f17becfbea5 ("vrf: check the original netdevice for generating redirect")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Stephen Suryaputra <ssuryaextr@...il.com>
> ---
>  net/ipv6/ndisc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>