netdev - Re: [PATCH net-next 2/5] tcp: add a @pace_delay parameter to tcp_reset_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQy=XOdoS8b=h6i3V39BJ=fC_-hBS2L91FsExFqwJi-oErA@mail.gmail.com>
Date: Sat, 8 Feb 2025 17:46:48 -0600
From: Neal Cardwell <ncardwell@...gle.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: Eric Dumazet <edumazet@...gle.com>, "David S . Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, Jason Xing <kernelxing@...cent.com>, 
	Simon Horman <horms@...nel.org>, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 2/5] tcp: add a @pace_delay parameter to tcp_reset_xmit_timer()

On Fri, Feb 7, 2025 at 11:31 PM Jason Xing <kerneljasonxing@...il.com> wrote:
>
> On Fri, Feb 7, 2025 at 11:30 PM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > We want to factorize calls to inet_csk_reset_xmit_timer(),
> > to ease TCP_RTO_MAX change.
> >
> > Current users want to add tcp_pacing_delay(sk)
> > to the timeout.
> >
> > Remaining calls to inet_csk_reset_xmit_timer()
> > do not add the pacing delay. Following patch
> > will convert them, passing false for @pace_delay.
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>
> Reviewed-by: Jason Xing <kerneljasonxing@...il.com>

Reviewed-by: Neal Cardwell <ncardwell@...gle.com>

Thanks, Eric!

neal