netdev - Re: [PATCH] net: dsa: microchip: KSZ8563 register regmap alignment to 32 bit boundaries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250207170037.06d853af@kernel.org>
Date: Fri, 7 Feb 2025 17:00:37 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Thorsten Scherer <t.scherer@...elmann.de>
Cc: netdev@...r.kernel.org, Woojung Huh <woojung.huh@...rochip.com>,
 UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Rasmus Villemoes <linux@...musvillemoes.dk>,
 kernel@...gutronix.de
Subject: Re: [PATCH] net: dsa: microchip: KSZ8563 register regmap alignment
 to 32 bit boundaries

On Thu,  6 Feb 2025 13:22:45 +0100 Thorsten Scherer wrote:
> -	regmap_reg_range(0x1122, 0x1127),
> -	regmap_reg_range(0x112a, 0x112b),
> -	regmap_reg_range(0x1136, 0x1139),
> -	regmap_reg_range(0x113e, 0x113f),
> +	regmap_reg_range(0x1120, 0x112b),
> +	regmap_reg_range(0x1134, 0x113b),
> +	regmap_reg_range(0x113c, 0x113f),

can these two not be merged?

>  	regmap_reg_range(0x1400, 0x1401),
>  	regmap_reg_range(0x1403, 0x1403),
>  	regmap_reg_range(0x1410, 0x1417),
> @@ -747,10 +746,9 @@ static const struct regmap_range ksz8563_valid_regs[] = {
>  	regmap_reg_range(0x2030, 0x2030),
>  	regmap_reg_range(0x2100, 0x2111),
>  	regmap_reg_range(0x211a, 0x211d),
> -	regmap_reg_range(0x2122, 0x2127),
> -	regmap_reg_range(0x212a, 0x212b),
> -	regmap_reg_range(0x2136, 0x2139),
> -	regmap_reg_range(0x213e, 0x213f),
> +	regmap_reg_range(0x2120, 0x212b),
> +	regmap_reg_range(0x2134, 0x213b),
> +	regmap_reg_range(0x213c, 0x213f),

and these?
-- 
pw-bot: cr