netdev - Re: [PATCH 1/9] of: Add warpper function of_find_node_by_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be93486b-91bb-4fdd-9f6c-ec295c448476@stanley.mountain>
Date: Sat, 8 Feb 2025 07:18:52 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: "zhangzekun (A)" <zhangzekun11@...wei.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>, robh@...nel.org,
	saravanak@...gle.com, justin.chen@...adcom.com,
	florian.fainelli@...adcom.com, andrew+netdev@...n.ch,
	kuba@...nel.org, kory.maincent@...tlin.com,
	jacopo+renesas@...ndi.org, kieran.bingham+renesas@...asonboard.com,
	maddy@...ux.ibm.com, mpe@...erman.id.au, npiggin@...il.com,
	olteanv@...il.com, davem@...emloft.net, taras.chornyi@...ision.eu,
	edumazet@...gle.com, pabeni@...hat.com, sudeep.holla@....com,
	cristian.marussi@....com, arm-scmi@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-media@...r.kernel.org,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	chenjun102@...wei.com, Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Subject: Re: [PATCH 1/9] of: Add warpper function
 of_find_node_by_name_balanced()

On Fri, Feb 07, 2025 at 05:37:22PM +0200, Laurent Pinchart wrote:
> I'm tempted to then rename of_find_node_by_name() to
> __of_find_node_by_name() to indicate it's an internal function not meant
> to be called except in special cases. It could all be renamed to
> __of_find_next_node_by_name() to make its behaviour clearer.
> 

Adding "next" to the name would help a lot.

Joe Hattori was finding some of these bugs using his static checker.
We could easily write something really specific to find this sort of
bug using Smatch.  If you have ideas like this feel free to ask on
smatch@...r.kernel.org.  It doesn't find anything that your grep
didn't find but any new bugs will be detected when they're introduced.

regards,
dan carpenter

View attachment "err-list" of type "text/plain" (426 bytes)

View attachment "check_of_find_node_by_name.c" of type "text/x-csrc" (1177 bytes)