netdev - Re: [PATCH v2 06/13] iio: adc: ad7606: use gpiod_multi_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250208132313.5b151ca0@jic23-huawei>
Date: Sat, 8 Feb 2025 13:23:13 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Linus Walleij
 <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Andy
 Shevchenko <andy@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Ulf Hansson <ulf.hansson@...aro.org>, Peter
 Rosin <peda@...ntia.se>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vinod Koul
 <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>, Nuno
 Sá <nuno.sa@...log.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi
 Iwai <tiwai@...e.com>, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 linux-mmc@...r.kernel.org, netdev@...r.kernel.org,
 linux-phy@...ts.infradead.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH v2 06/13] iio: adc: ad7606: use
 gpiod_multi_set_value_cansleep

On Fri, 7 Feb 2025 14:13:23 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Fri, Feb 7, 2025 at 12:48 AM David Lechner <dlechner@...libre.com> wrote:
> >
> > Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
> > gpiod_set_array_value().
> >
> > These are not called in an atomic context, so changing to the cansleep
> > variant is fine.  
> 
> ...
> 
> >         if (st->gpio_os) {
> > -               gpiod_set_array_value(st->gpio_os->ndescs,
> > -                                     st->gpio_os->desc, st->gpio_os->info, os);
> > +               gpiod_multi_set_value_cansleep(st->gpio_os, os);
> >         }  
> 
> Now I do not see any justification to leave {}.
> 
With that tidied up (good spot!) if this goes through the GPIO tree
Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>