netdev - Re: [PATCH v1 3/3] arm: dts: stm32: Add Plymovent AQM devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc413dad-e167-4f4c-9ab2-b2ae77954839@kernel.org>
Date: Sun, 9 Feb 2025 17:36:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Woojung Huh <woojung.huh@...rochip.com>, Andrew Lunn <andrew+netdev@...n.ch>
Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH v1 3/3] arm: dts: stm32: Add Plymovent AQM devicetree

On 07/02/2025 15:32, Oleksij Rempel wrote:
> +
> +&spi2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi2_aqm_pins_a>;
> +	status = "disabled";
> +
> +	spidev@0 {
> +		compatible = "dh,dhcom-board"; /* Needed for spidev in userspace */

But that's not a dhcom-board.

NAK, you are abusing DT for instantiating user-space modules. Either you
have here one, fixed, real device or not. If not, you must drop it. If
yes, describe this one, fixed, real device.

Best regards,
Krzysztof